Skip to content

Add pytest-based tests #5860

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Open
hoodmane wants to merge 2 commits into
base: main
Choose a base branch
from
Open

Add pytest-based tests #5860

hoodmane wants to merge 2 commits into from

Conversation

@hoodmane
Copy link
Contributor

@hoodmane hoodmane commented Jan 9, 2026

No description provided.

@hoodmane hoodmane force-pushed the hoodmane/pytest branch 6 times, most recently from d7565c4 to 06593b1 Compare January 9, 2026 02:15
@codspeed-hq
Copy link

codspeed-hq bot commented Jan 9, 2026 •
edited
Loading

CodSpeed Performance Report

Merging this PR will not alter performance

Comparing hoodmane/pytest (0fddb86) with main (612919d)

Summary

✅ 129 untouched benchmarks
⏩ 49 skipped benchmarks1

Footnotes

  1. 49 benchmarks were skipped, so the baseline results were used instead. If they were deleted from the codebase, click here and archive them to remove them from the performance reports. ↩

@hoodmane hoodmane force-pushed the hoodmane/pytest branch 2 times, most recently from 23d3bbc to b73de30 Compare January 9, 2026 17:55
@hoodmane hoodmane marked this pull request as ready for review January 9, 2026 17:56
@hoodmane hoodmane requested review from a team as code owners January 9, 2026 17:56
@hoodmane hoodmane force-pushed the hoodmane/pytest branch 4 times, most recently from 1dbbcfc to 13e318a Compare January 9, 2026 18:09
@hoodmane hoodmane requested a review from a team as a code owner January 9, 2026 18:09
@hoodmane hoodmane force-pushed the hoodmane/pytest branch 2 times, most recently from 3c6899d to f54c75a Compare January 9, 2026 18:31
@hoodmane hoodmane force-pushed the hoodmane/pytest branch 2 times, most recently from 9114514 to af5cfb2 Compare January 9, 2026 23:44
@github-actions
Copy link

github-actions bot commented Jan 9, 2026


Thank you for your submission, we really appreciate it. Like many open-source projects, we ask that you all sign our Contributor License Agreement before we can accept your contribution. You can sign the CLA by just posting a Pull Request Comment same as the below format.

I have read the CLA Document and I hereby sign the CLA

1 out of 2 committers have signed the CLA.
✅ (hoodmane)[https://github.com/hoodmane]
❌ @actions-user
You can retrigger this bot by commenting recheck in this Pull Request. Posted by the CLA Assistant Lite bot.

@actions-user @hoodmane
fixup! Add pytest-based tests
0fddb86 
Update python_metadata.bzl with new bundle info

This commit updates the backport and integrity values in python_metadata.bzl
based on the latest Pyodide bundle upload.

🤖 Generated automatically by release-python-runtime workflow
@danlapid
Copy link
Collaborator

danlapid commented Jan 10, 2026

This is so smart - and cool!
Once we're done we should package this to a native python testing framework within workers for workers!
Like our vitest integration.
@petebacondarwin @penalosa

ryanking13
ryanking13 reviewed Jan 12, 2026
View reviewed changes
src/pyodide/internal/pool/emscriptenSetup.ts
PYTHONHASHSEED: '111',
},
lockFileURL: '',
enableRunUntilComplete: true,
Copy link
Contributor

@ryanking13 ryanking13 Jan 12, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Is this a non-breaking change for old workers that use Pyodide < 0.28?

src/workerd/server/tests/python/pytest/main.py
Comment on lines +13 to +14
WebLoop.shutdown_asyncgens = noop
WebLoop.shutdown_default_executor = noop
Copy link
Contributor

@ryanking13 ryanking13 Jan 12, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Maybe let's add a comment why we need this, something like:

pytest-asyncio relies on this method, but Pyodide < 0.29 does not implement these methods in the webloop class, so we stub these out...

dom96
dom96 approved these changes Jan 12, 2026
View reviewed changes
Copy link
Contributor

@dom96 dom96 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice!

src/workerd/server/tests/python/BUILD.bazel

# Each test takes a while to start up, so if possible add additional tests to many-tests or sdk or
# some other existing test.
# Each test takes a while to start up, so if possible add additional tests to pytest or to
Copy link
Contributor

@dom96 dom96 Jan 12, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
# Each test takes a while to start up, so if possible add additional tests to pytest or to
# NOTE: Each test takes a while to start up, so if possible add additional tests to pytest or to

src/workerd/server/tests/python/BUILD.bazel
# Each test takes a while to start up, so if possible add additional tests to pytest or to
# top-level-tests or sdk or some other existing test.

# TODO: Why does this break with snapshots?
Copy link
Contributor

@dom96 dom96 Jan 12, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can we create an EW ticket to track this (and then put its number into the comment)?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@ryanking13 ryanking13 ryanking13 left review comments

@dom96 dom96 dom96 approved these changes

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

5 participants

@hoodmane @danlapid @dom96 @ryanking13 @actions-user