Skip to content

Conversation

@woustachemax
Copy link

Changes both implementation and tests to use canonical encoding names:

  • 'ibm-866' - 'ibm866'
  • 'shift-jis' - 'shift_jis'
    Per WHATWG Encoding Standard, TextDecoder.encoding should return the canonical encoding name, not the label used to construct it.

Fixes #5663

Changes both implementation and tests to use canonical encoding names:
- 'ibm-866' → 'ibm866' (remove hyphen)
- 'shift-jis' → 'shift_jis' (use underscore)

Per WHATWG Encoding Standard, TextDecoder.encoding should return
the canonical encoding name, not the label used to construct it.

Fixes cloudflare#5663
@woustachemax woustachemax requested review from a team as code owners January 8, 2026 14:30
@github-actions
Copy link

github-actions bot commented Jan 8, 2026

All contributors have signed the CLA ✍️ ✅
Posted by the CLA Assistant Lite bot.

@woustachemax
Copy link
Author

I have read the CLA Document and I hereby sign the CLA

github-actions bot added a commit that referenced this pull request Jan 8, 2026
@codspeed-hq
Copy link

codspeed-hq bot commented Jan 8, 2026

Merging this PR will degrade performance by 18.79%

Summary

❌ 1 regressed benchmark
✅ 128 untouched benchmarks
⏩ 49 skipped benchmarks1

⚠️ Please fix the performance issues or acknowledge them on CodSpeed.

Performance Changes

Benchmark BASE HEAD Efficiency
jsonResponse[Response] 34.6 µs 42.7 µs -18.79%

Comparing woustachemax:fix-encoding-canonical-names (2977ef0) with main (6bacc75)

Open in CodSpeed

Footnotes

  1. 49 benchmarks were skipped, so the baseline results were used instead. If they were deleted from the codebase, click here and archive them to remove them from the performance reports.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

ibm866 encoding label appears incorrect in tests

1 participant