-
Notifications
You must be signed in to change notification settings - Fork 43
mp: Added no-ssl verification in dev-env deploy #367
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Conversation
Summary of ChangesHello @lemanczykp, I'm Gemini Code Assist1! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed! This pull request introduces a new Highlights
Using Gemini Code AssistThe full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips. Invoking Gemini You can request assistance from Gemini at any point by creating a comment using either
Customization To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a Limitations & Feedback Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for Github and other Google products, sign up here. You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension. Footnotes
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Code Review
This pull request introduces a --no-ssl flag to the dev-env login and dev-env push commands, allowing users to disable SSL certificate verification. This is a useful feature for local development environments. The implementation correctly passes the flag down to the BackendAPI to control the requests session's verification behavior.
My review includes a few suggestions to improve the code:
- Refactoring the
BackendAPIinstantiation in bothloginandpushcommands to reduce code duplication. - Suppressing the
InsecureRequestWarningthatrequestsissues when SSL verification is disabled, which will improve the user experience as mentioned in the PR description.
Overall, the changes are well-implemented and address the intended goal.
|
Hey, do you want to fix the lint issues ? |
|
@doriaviram Hi, this feature is mostly for ease of local development and was not requested. The lint issues require a bit of rework and retest for which I recently did not have "spare" time. Will try to wrap it during this or next week. |
|
@doriaviram Hi, streamlined handling of localhost a bit so it does not require separate parameter for TLS disabling but now it does it on its own. Let me know if this is ok for you. |
mp tool: Optional disabling ssl verification for dev-env push
Description
Disables ssl when pushing the integration to a development env. This is usefull for localhost deployments.
Example usage:
When using this param the tools throws new warnings
Checklist:
Please ensure you have completed the following items before submitting your PR.
This helps us review your contribution faster and more efficiently.
General Checks:
Open-Source Specific Checks:
For Google Team Members and Reviewers Only: