Don't override prefix if already given #340
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Keys might be `['enter']`, but I want the prefix to say `Enter`.
GottZ
reviewed
Jan 30, 2019
GottZ
left a comment
GottZ
left a comment
There was a problem hiding this comment.
so just to be on the same page as you.. it checks if the item is an object, a function or a string and in each case assigns a prefix automagically.
now your condition checks if the prefix is null. how would it be possible to evaluate to true? an array is also an object and except number not much comes to mind that could run into that expression.
i'm not too familiar with this project yet but i think your change would be a breaking change in case you use an object as item and expect it to take .keys[0] as prefix automagically.
|
@oliversturm I have added |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Keys might be
['enter'], but I want the prefix to sayEnter.