Skip to content

add "pkg" entry to package.json #326

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Open
TooTallNate wants to merge 1 commit into
base: master
Choose a base branch
from
Open

add "pkg" entry to package.json #326

TooTallNate wants to merge 1 commit into from
+3 −0

Conversation

@TooTallNate
Copy link

@TooTallNate TooTallNate commented Dec 15, 2017

To whitelist the dynamically required files in the lib/widgets dir when building with pkg.

Closes #298.

@TooTallNate
add "pkg" entry to package.json
c55f985 
To whitelist the dynamically required files in the `lib/widgets` dir

Closes chjj#298.
@TooTallNate TooTallNate mentioned this pull request Dec 15, 2017
Open
@JoshMcCullough
Copy link

JoshMcCullough commented Feb 12, 2019

Any chance of merging this soon?

@arseniosiani
Copy link

arseniosiani commented Sep 3, 2023

+1

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

1 more reviewer

@GottZ GottZ GottZ approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Dynamically-assembled require() calls in lib/widget.js break pkg/nexe support

4 participants

@TooTallNate @JoshMcCullough @arseniosiani @GottZ