Skip to content

Conversation

Copy link

Copilot AI commented Oct 29, 2025

Integrates Apache Thrift 0.11.0 into the build infrastructure to enable Thrift protocol support in brpc.

Changes

  • CI workflow: Added Thrift 0.11.0 installation step in GitHub Actions, installing to /usr for unified dependency management
  • Build configuration: Updated config_brpc.sh to detect Thrift binary and libraries when --with-thrift is enabled
  • Test infrastructure: Modified test/Makefile to compile Thrift-generated sources from echo.thrift, producing gen-cpp/ directory
  • Dependency consolidation: Moved gperftools and abseil-cpp installation from custom prefixes to /usr to simplify header/lib path management

Build system integration

The Thrift compiler generates C++ sources at build time:

gen-cpp/echo_types.cpp gen-cpp/echo_types.h: echo.thrift
	$(THRIFT) --gen cpp $<

Generated files are automatically included in test builds and excluded via .gitignore.


✨ Let Copilot coding agent set things up for you — coding agent works faster and does higher quality work when set up for your repo.

Copilot AI mentioned this pull request Oct 29, 2025
Copilot AI changed the title [WIP] Fix Thrift single issue with performance effects Add Thrift support to build system and CI Oct 29, 2025
Copilot AI requested a review from chenBright October 29, 2025 12:41
@chenBright chenBright force-pushed the thrift_single branch 3 times, most recently from 2bc2f4e to 509b558 Compare October 30, 2025 12:06
@chenBright chenBright closed this Oct 30, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants