Skip to content

Introduce subscription set id field ana-174 #177

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
SrikalaB merged 3 commits into from
Nov 26, 2025
Merged

Introduce subscription set id field ana-174 #177

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
3efa2dc
Introduce set id field ana-174
SrikalaB Nov 17, 2025
6874b8c
Ruby 4.0.0(head) is incompatible with bundler ~> 2, removing bundler …
SrikalaB Nov 18, 2025
d1de6e5
Fix tests [ana-174]
SrikalaB Nov 18, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 0 additions & 1 deletion chartmogul-ruby.gemspec
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -31,7 +31,6 @@ Gem::Specification.new do |spec|
spec.add_dependency 'faraday-retry', '~> 2.2'

# Higher versions break ruby 2.7 support.
spec.add_development_dependency 'bundler', '~> 2'
spec.add_development_dependency 'cgi'
spec.add_development_dependency 'pry'
spec.add_development_dependency 'rake'
Expand Down
1 change: 1 addition & 0 deletions lib/chartmogul/metrics/activity.rb
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -11,6 +11,7 @@ class Activity < ChartMogul::Object
readonly_attr :activity_mrr_movement
readonly_attr :currency
readonly_attr :subscription_external_id
readonly_attr :subscription_set_external_id
readonly_attr :plan_external_id
readonly_attr :customer_name
readonly_attr :customer_uuid
Expand Down
1 change: 1 addition & 0 deletions spec/chartmogul/metrics/activities_spec.rb
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -25,6 +25,7 @@
expect(activity.activity_mrr_movement).not_to be_nil
expect(activity.currency).not_to be_nil
expect(activity.subscription_external_id).not_to be_nil
expect(activity.subscription_set_external_id).not_to be_nil
expect(activity.plan_external_id).not_to be_nil
expect(activity.customer_name).not_to be_nil
expect(activity.customer_uuid).not_to be_nil
Expand Down
4 changes: 2 additions & 2 deletions ...settes/ChartMogul_Metrics_Activity/behaves_like_PageableWithAnchor/should_be_pageable.yml
View file
Open in desktop

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

4 changes: 2 additions & 2 deletions spec/fixtures/vcr_cassettes/ChartMogul_Metrics_Activity/should_have_Activity_entries.yml
View file
Open in desktop

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

4 changes: 2 additions & 2 deletions ...settes/ChartMogul_Metrics_Activity/should_paginate_using_cursor_when_called_with_next.yml
View file
Open in desktop

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.