Stick marshmallow to 3 version #108
Conversation
|
Code Climate has analyzed commit 5f40290 and detected 0 issues on this pull request. The test coverage on the diff in this pull request is 100.0% (50% is the threshold). This pull request will bring the total coverage in the repository to 98.5% (0.0% change). View more on Code Climate. |
| uritemplate>=3.0.0 | ||
| promise>=1.0.1 | ||
| marshmallow>=3.19.0 | ||
| marshmallow>=3.19.0,<3.24.0 |
There was a problem hiding this comment.
There is a breaking change in Marshmallow 3.24. We need to stop using fields.Number according to that change. I am not sure at the moment how that might affect us, so we'll look at that later.
There was a problem hiding this comment.
It looks like it was just deprecated in 3.24 and not breaking until 4.0 where it's actually removed. We've been using 3.26.1 for the past 2 months and haven't noticed any issues. Nice catch and callout, though!
There was a problem hiding this comment.
It was breaking our tests, so I restricted it for now. Sorry for inconvenience.
There was a problem hiding this comment.
ah, ok. I thought maybe it was just based on the changelog so wanted to point that out. It's weird that it broke the tests when it definitely shouldn't have (ie. it should have just been a deprecation and not a breaking change on Marshmallow's end).
When can we expect a release?
swember
deleted the
dmitriydavydov/sc-67157/restrict-marshmallow-dep-by-4-version-in
branch
3 participants
#107