Skip to content

Conversation

@davidlacho
Copy link
Contributor

Update urllib3 dependency to allow future minor updates

Description

This PR updates the urllib3 dependency in requirements.txt to use >=2.2.3 instead of ==2.2.3. This change allows for future minor updates while maintaining compatibility with other dependencies.

Changes

  • Updated requirements.txt to use urllib3>=2.2.3
  • Updated CHANGELOG.md to reflect this change in version 4.5.1

Testing

  • Verified that the package installs correctly with the new dependency constraint
  • Ran existing test suite to ensure compatibility

Related Issues

  • This change helps prepare for future dependency updates while maintaining current compatibility
  • Part of ongoing dependency management and security updates

Release Notes

This change will be released as version 4.5.1, following semantic versioning principles as it's a backward-compatible dependency update.

@davidlacho
Copy link
Contributor Author

@mynameispedro Unable to run test suite as an open source contributor without access to the project's test runners. Would appreciate if maintainers could run the test suite to verify compatibility.

@mynameispedro
Copy link
Contributor

@davidlacho,

I'll approve because the tests are green. It's the codeclimate part that fails.

I'll just wait for 1 more approval and merge it.

@swember swember merged commit 5553dda into chartmogul:main Apr 9, 2025
2 of 7 checks passed
@davidlacho
Copy link
Contributor Author

Thanks @swember and @mynameispedro . Can we get this released? This is blocking us being able to ugprade our deps.

@mynameispedro
Copy link
Contributor

@davidlacho

Done ✅

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants