Skip to content

Conversation

@wscourge
Copy link
Contributor

@wscourge wscourge commented Dec 2, 2025

Updates the test to confirm support of List Sources and Retrieve a Source requesting additional fields with the following query params:

  • with_processing_status=true
  • with_auto_churn_subscription_setting=true
  • with_invoice_handling_setting=true

Using SDK code:

1) List Sources

DataSource.all(config, {
  with_processing_status: true,
  with_auto_churn_subscription_setting: true,
  with_invoice_handling_setting: true
})

2) Retrieve a Source

DataSource.retrieve(config, "uuid", {
  with_processing_status: true,
  with_auto_churn_subscription_setting: true,
  with_invoice_handling_setting: true
})

@wscourge wscourge force-pushed the wiktor/ome-356-expose-source-settings-via-api branch from d503414 to 0b09496 Compare December 2, 2025 14:56
@wscourge wscourge requested a review from Copilot December 2, 2025 14:57
Copy link

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

This PR adds comprehensive test coverage for DataSource API methods with optional query parameters (with_processing_status, with_auto_churn_subscription_setting, with_invoice_handling_setting) for both listing and retrieving data sources. The tests verify that these parameters are properly passed to the API and that the expected fields are returned in responses.

Key Changes

  • Added 10 new test cases covering individual and combined optional parameters for DataSource.all() and DataSource.retrieve()
  • Added tests for filtering data sources by name and system parameters
  • Updated README.md to reflect the optional query parameter for DataSource.retrieve()

Reviewed changes

Copilot reviewed 2 out of 2 changed files in this pull request and generated no comments.

File Description
test/chartmogul/data-source.js Added comprehensive test coverage for optional query parameters in DataSource list and retrieve operations
README.md Updated method signature to include optional query parameter for retrieve method

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

@wscourge wscourge requested a review from tudorpavel December 9, 2025 09:38
@wscourge wscourge merged commit 720c9e6 into main Dec 17, 2025
4 checks passed
@wscourge wscourge deleted the wiktor/ome-356-expose-source-settings-via-api branch December 17, 2025 14:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants