Update retrieve to accept query params #81
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
There was a problem hiding this comment.
Pull request overview
This PR adds support for query parameters to the RetrieveInvoice method, allowing callers to specify validation type, include edit histories, and include disabled invoices. The changes align with similar functionality already available in ListAllInvoices.
- Added
RetrieveInvoiceParamsstruct to support optional query parameters for invoice retrieval - Updated
RetrieveInvoiceto accept variadicRetrieveInvoiceParamsfor backward compatibility - Extended
ListAllInvoicesParamswith validation type, edit histories, and disabled invoices fields
Reviewed changes
Copilot reviewed 3 out of 3 changed files in this pull request and generated 1 comment.
| File | Description |
|---|---|
| invoices.go | Added RetrieveInvoiceParams struct and updated RetrieveInvoice signature to accept optional parameters; added query parameter fields to ListAllInvoicesParams |
| chartmogul.go | Updated IApi interface signature for RetrieveInvoice to include variadic params |
| invoices_test.go | Added comprehensive test coverage for new query parameters in both ListAllInvoices and RetrieveInvoice methods |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
pkopac
approved these changes
Jan 1, 2026
wscourge
deleted the
wiktor/ome-418-add-validation_type-support-to-invoices-line-items-and
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.