-
Notifications
You must be signed in to change notification settings - Fork 3
Add --line-length parameter to format subcommand for cf policy files #4
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
39b898e to
2311423
Compare
|
Thanks for submitting a PR! Maybe @craigcomstock can review this? |
craigcomstock
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Seems reasonable. Good to keep existing behavior with defaults. 👍
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hello!
Thank you for opening a pull request. In general we don't want too much customizability in this formatter, since the goal of it is to make consistent looking policy files. (If everyone is customizing their formatters then they're no longer consistent, or perhaps less consistent than if they all used the same style).
With that said, I think it's okay to allow for customizable line lengths, at least for now.
In order to get this merged, please address the following:
- Remove the commit concerning customizing indent
- Change the command line option to
--line-length - Change the places where you are sending
argsobjects to functions, use an explicit parameter with an appropriate name instead (line_length). - Add a simple shell test where you run the tool with different
--line-lengthvalues, and check that it works correctly.
Let me know if you have any questions!
2311423 to
cc7b876
Compare
cc7b876 to
e74c980
Compare
olehermanse
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This looks ready now, thanks for your contribution! (In the future, feel free to open an issue to discuss something before implementing :) )
No description provided.