-
Notifications
You must be signed in to change notification settings - Fork 14
chore(cli): Add workspace packages to test-project fixture #920
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Conversation
✅ Deploy Preview for cedarjs canceled.
|
Greptile SummaryRefactored the build command structure by extracting package building logic into a separate Key Changes:
Benefits:
Confidence Score: 5/5
Important Files Changed
Sequence DiagramsequenceDiagram
participant User
participant BuildCommand as build.js
participant BuildHandler as buildHandler.js
participant BuildPackages as buildPackagesTask.js
participant FS as FileSystem
participant Concurrently
User->>BuildCommand: cedar build [workspace]
BuildCommand->>BuildHandler: handler(options)
alt nonApiWebWorkspaces.length > 0
BuildHandler->>BuildPackages: buildPackagesTask(nonApiWebWorkspaces)
alt workspace includes 'packages/*'
BuildPackages->>FS: glob(cedarPaths.packages/*)
FS-->>BuildPackages: ['/path/to/pkg1', '/path/to/pkg2']
else specific workspaces
BuildPackages->>FS: existsSync(workspacePath)
FS-->>BuildPackages: true/false
end
BuildPackages->>Concurrently: run yarn build in parallel
Concurrently-->>BuildPackages: result promise
BuildPackages-->>BuildHandler: completed
end
BuildHandler->>BuildHandler: continue with other build tasks
BuildHandler-->>BuildCommand: build complete
BuildCommand-->>User: success
|
|
| Command | Status | Duration | Result |
|---|---|---|---|
nx run-many -t test --minWorkers=1 --maxWorkers=4 |
✅ Succeeded | 3s | View ↗ |
nx run-many -t test:types |
✅ Succeeded | 9s | View ↗ |
nx run-many -t build:pack --exclude create-ceda... |
✅ Succeeded | 4s | View ↗ |
nx run-many -t build |
✅ Succeeded | 3m 14s | View ↗ |
☁️ Nx Cloud last updated this comment at 2026-01-04 15:01:29 UTC
cedar build test and test-fixture
cedar build test and test-fixturecedar build test + test project fixture
cedar build test + test project fixture
Having workspace packages in our test-project fixture, including code to add them using the Cedar CLI is the best way to ensure the feature works and no regressions are introduced in the future