-
Notifications
You must be signed in to change notification settings - Fork 14
feat(cli): cedar build now also builds all packages
#915
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
✅ Deploy Preview for cedarjs canceled.
|
|
| Command | Status | Duration | Result |
|---|---|---|---|
nx run-many -t test --minWorkers=1 --maxWorkers=4 |
✅ Succeeded | 1m 50s | View ↗ |
nx run-many -t build:pack --exclude create-ceda... |
✅ Succeeded | 3s | View ↗ |
nx run-many -t build |
✅ Succeeded | 3m 25s | View ↗ |
nx run-many -t test:types |
✅ Succeeded | 12s | View ↗ |
☁️ Nx Cloud last updated this comment at 2026-01-03 05:10:24 UTC
|
| Command | Status | Duration | Result |
|---|---|---|---|
nx run-many -t test --minWorkers=1 --maxWorkers=4 |
❌ Failed | 1m 17s | View ↗ |
nx run-many -t build |
✅ Succeeded | 10s | View ↗ |
nx run-many -t test:types |
✅ Succeeded | 6s | View ↗ |
nx run-many -t build:pack --exclude create-ceda... |
✅ Succeeded | 7s | View ↗ |
☁️ Nx Cloud last updated this comment at 2026-01-02 22:21:21 UTC
|
| Command | Status | Duration | Result |
|---|---|---|---|
nx run-many -t test --minWorkers=1 --maxWorkers=4 |
❌ Failed | 1m 17s | View ↗ |
nx run-many -t build |
✅ Succeeded | 7s | View ↗ |
nx run-many -t test:types |
✅ Succeeded | 6s | View ↗ |
nx run-many -t build:pack --exclude create-ceda... |
✅ Succeeded | 7s | View ↗ |
☁️ Nx Cloud last updated this comment at 2026-01-02 22:21:25 UTC
|
| Command | Status | Duration | Result |
|---|---|---|---|
nx run-many -t test --minWorkers=1 --maxWorkers=4 |
❌ Failed | 1m 17s | View ↗ |
nx run-many -t build:pack --exclude create-ceda... |
✅ Succeeded | 7s | View ↗ |
nx run-many -t build |
✅ Succeeded | 7s | View ↗ |
nx run-many -t test:types |
✅ Succeeded | 6s | View ↗ |
☁️ Nx Cloud last updated this comment at 2026-01-02 22:22:23 UTC
Greptile SummaryExtended Key changes:
Confidence Score: 4/5
Important Files Changed
Sequence DiagramsequenceDiagram
participant User
participant CLI as build.js
participant Handler as buildHandler.js
participant Project as project.js
participant FS as File System
participant Concurrently
User->>CLI: cedar build [workspace..]
CLI->>CLI: Parse workspace args
alt workspace filtering needed
CLI->>Project: workspaces({includePackages: true})
Project->>FS: glob packages/*/package.json
FS-->>Project: package paths
Project->>FS: read package.json files
FS-->>Project: package names
Project-->>CLI: all valid workspace names
CLI->>CLI: validate workspace args
end
CLI->>Handler: handler(options)
Handler->>FS: read package.json workspaces
FS-->>Handler: workspace config
alt packages to build
Handler->>FS: glob packages/*
FS-->>Handler: all package paths
alt specific packages requested
Handler->>Handler: map workspace names to paths
Handler->>FS: check path existence
FS-->>Handler: path exists
end
Handler->>Concurrently: build packages in parallel
Concurrently->>FS: yarn build (multiple packages)
FS-->>Concurrently: build results
Concurrently-->>Handler: completion status
end
alt api workspace included
Handler->>Handler: verify schema & build API
end
alt web workspace included
Handler->>Handler: build Web
end
Handler-->>User: build complete
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
5 files reviewed, 2 comments
| : restWorkspaces.map((w) => { | ||
| return path.join(cedarPaths.packages, w.split('/').at(-1)) | ||
| }) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
logic: path mapping assumes directory name matches last segment of scoped package name. for @my-org/my-package, this creates path packages/my-package, but directory could actually be named differently (e.g., just the org name or a different structure)
check if the mapped path exists before using it, or verify the package.json name matches. are package directory names guaranteed to match the last segment of the package name in your workspace setup?
Prompt To Fix With AI
This is a comment left during a code review.
Path: packages/cli/src/commands/buildHandler.js
Line: 92:94
Comment:
**logic:** path mapping assumes directory name matches last segment of scoped package name. for `@my-org/my-package`, this creates path `packages/my-package`, but directory could actually be named differently (e.g., just the org name or a different structure)
check if the mapped path exists before using it, or verify the package.json name matches. are package directory names guaranteed to match the last segment of the package name in your workspace setup?
How can I resolve this? If you propose a fix, please make it concise.cedar build now builds all packagescedar build now builds all workspaces
cedar build now builds all workspacescedar build now also builds all packages
|
@greptileai Please do a full review again, and update your review summary post |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
4 files reviewed, 1 comment

yarn cedar buildused to only build the "web" and "api"sidesworkspaces. Now it builds web, api and all packagesOutput is a bit rough, but it works!