Skip to content

Conversation

@SamHasler
Copy link

If any property in the object passed to add is an array it will run the test for each value in the array.
When you want to run many similar tests this makes configuring them more concise / DRY.

e.g.:

   csscritic.add({ url: ['test-a.html','test-b.html']
                 , height: 200
                 , [320,640,800,1024,1280]
                 })
            .execute();

If any property in the object passed to `add` is an array it will run the test for each value in the array.
When you want to run many similar tests this makes configuring them more concise / DRY.
@cburgmer
Copy link
Owner

cburgmer commented Sep 8, 2015

Thanks for that, I like the idea.

Can you also add a test to make sure this behaviour does not get broken in the future? This is going to be in the central API, and we need to guarantee that this never changes between major releases. To me it looks like test/specs/mainSpec.js is a good starting point for adding such a test.

@SamHasler
Copy link
Author

Ok, I'll have a look at making a test.
On Sep 8, 2015 3:15 PM, "Christoph Burgmer" notifications@github.com
wrote:

Thanks for that, I like the idea.

Can you also add a test to make sure this behaviour does not get broken in
the future? This is going to be in the central API, and we need to
guarantee that this never changes between major releases. To me it looks
like test/specs/mainSpec.js is a good starting point for adding such a
test.


Reply to this email directly or view it on GitHub
#64 (comment).

@cburgmer
Copy link
Owner

cburgmer commented Oct 3, 2015

Let me know if you need any help here.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants