Format, fix, document, Etc 04/15 #394
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Clippy says these `else` blocks are redundant: [https://rust-lang.github.io/rust-clippy/master/index.html#redundant_else]
Clippy says the logic reads better the other way around: [https://rust-lang.github.io/rust-clippy/master/index.html#if_not_else] or there's a simpler way: [https://rust-lang.github.io/rust-clippy/master/index.html#bool_to_int_with_if]
Clippy says it's better to borrow with the `&` when possible: [https://rust-lang.github.io/rust-clippy/master/index.html#explicit_deref_methods] It's what the reader would be expecting.
Clippy says it's better to use a semicolon to avoid giving the impression that something is being returned: [https://rust-lang.github.io/rust-clippy/master/index.html#semicolon_if_nothing_returned]
Clippy says it's better to use methods directly, rather than construct closures that trivially wrap the methods: [https://rust-lang.github.io/rust-clippy/master/index.html#redundant_closure_for_method_calls] Clippy says it's better to call default methods of the struct, rather than the trait: [https://rust-lang.github.io/rust-clippy/master/index.html#default_trait_access]
Clippy says it's better to combine match arms that lead to the same outcome: [https://rust-lang.github.io/rust-clippy/master/index.html#match_same_arms]
Clippy says `from` is preferred to `as`, when available: [https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless]
This was referenced Sep 14, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Many small changes inspired by Clippy.
Previous PR in sequence was #393
Next PR in sequence was #399