Support for default filename in rffit output .dat file #82
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
xmichaelx
changed the title
| printf("Save highlighted points, provide filename [type 'default' for %s]: ",default_filename); | ||
| status = scanf("%s",filename); | ||
|
|
||
| if (strcmp(filename, "default") == 0 ) { |
Collaborator
There was a problem hiding this comment.
From the PR description, you can just type enter. From the code you have to explicitly type 'default'.
I would prefer the behavior of the description. So if the string is empty, use the proposed default, otherwise the provided filename.
Contributor
Author
There was a problem hiding this comment.
scanf does not allow for just entering empty string (simply hitting enter) or to be more precise - i did not found a way to just accept empty string - if you have an idea on how to handle both hitting enter to get default value and be able to provide filename then it would be most welcome.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Currently default name for file to be created is suggested but in order to accept it user has to copypaste it. This PR allows for just hitting enter and accepting the default filename. Proposed file name is presented in square brackets - pattern that is commonly used when default value can be provided by just hitting enter.
Allows for following: