Fix tests fstools

[dbungert]

The probert unit tests may fail, depending on if filesystem tools are installed on the host system. We don't actually run them, that's already mocked out. Mock out the check for them existing.

[mwhudson]

TIL @patch works on classes.

This is fine I guess. Did you consider a "ProbertTestCase" that does this mocking in setUp()?

[dbungert]

Did you consider a "ProbertTestCase" that does this mocking in setUp()?

I've pushed a sample commit with that, I think in this case it's not ideal as the name to patch is different for filesystem vs os. If I'm missing something let me know.

[mwhudson]

Did you consider a "ProbertTestCase" that does this mocking in setUp()?

I've pushed a sample commit with that, I think in this case it's not ideal as the name to patch is different for filesystem vs os. If I'm missing something let me know.

Hm that's true (and it looks like you're patching the wrong path in test_os now?). Can we just patch the shutil module direclty instead though?

[dbungert]

I pushed another version, I'm kind of ambivalent about the result though. I think in some cases this would be net beneficial but less so this one.

[mwhudson]

Hmm I think this is OK, but well. Do what you like :-)