Skip to content

Conversation

@chandrikarj
Copy link
Contributor

@chandrikarj chandrikarj commented Feb 12, 2025

Enhancements to XML import: Color parsing, polyline handling, independent annotations, and bounding boxes

Summary

-Color Representation Fix:
The line color in the XML annotation is now correctly parsed from a decimal representation to a hexadecimal format.

-Handling Polyline vs. Polygon:
The XML import utility now differentiates between Polyline and polygons.
Now, if the region type is Polyline, it is correctly mapped to a LineString, while Polygon regions remain unchanged.

-Independent Annotation Groups:
Each XML annotation group is now processed as a separate annotation object.

-Bounding Box Implementation:
The bounding box is calculated as the smallest enclosing rectangle around the annotation, using the min/max X and Y coordinates.

The videos demonstrating the changes are below :

Before:

Screen.Recording.2025-02-12.at.11.46.13.PM.mov

After:

Screen.Recording.2025-02-12.at.11.46.57.PM.mov

Motivation

This PR improves the XML import utility by addressing multiple issues outlined in Issue #1081.

@chandrikarj chandrikarj marked this pull request as draft February 12, 2025 20:58
@chandrikarj
Copy link
Contributor Author

Hey @birm,
Please take a look.

Also I feel like the GitHub Actions axe tests in are failing due to a ChromeDriver version mismatch. axe-cli is using Chrome 133 because GitHub Actions is installing the latest Chrome by default, but the workflow in .github/workflows/axe-a11y-check.yml is manually installing ChromeDriver 125, causing the failure. Just thought should let you know this is happening.

Thanks.

@chandrikarj chandrikarj marked this pull request as ready for review February 13, 2025 14:16
@birm birm self-requested a review February 15, 2025 02:52
@birm
Copy link
Member

birm commented Feb 18, 2025

Hi @chandrikarj -- don't worry about the axe check at this point.
I'll review this in earnest soon! Thanks for the contribution!

@birm birm merged commit 21fc84f into camicroscope:develop Feb 20, 2025
1 of 2 checks passed
@chandrikarj
Copy link
Contributor Author

Thanks, @birm

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants