disallow kebab fragment beginning with digit #2411
Closed
+48
−37
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Per the `word` and `acronym` grammar rules in https://github.com/WebAssembly/component-model/blob/main/design/mvp/Explainer.md#import-and-export-definitions, a kebab name must not contain a fragment beginning with a digit. This fixes [this test](https://github.com/WebAssembly/component-model/blob/b7fc86e31d71796f107aef276f0944ec6df70dba/test/wasm-tools/naming.wast#L25C1-L30C2) in the spec repo.
Member
|
This was changed here in this repo in #2355 and provisionally in the component model in WebAssembly/component-model#345, so I think that this might be a case of an upstream test that needs changing |
Collaborator
Author
|
Thanks for pointing that out, @alexcrichton . @lukewagner is going to update the spec when he gets a chance. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Per the
wordandacronymgrammar rules inhttps://github.com/WebAssembly/component-model/blob/main/design/mvp/Explainer.md#import-and-export-definitions, a kebab name must not contain a fragment beginning with a digit. This fixes this
test in the spec repo.