Set modified when creating QR code for box #804
+1
−1
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
HaGuesto
reviewed
Jan 21, 2026
| [$id, $hash] = generateQRIDForDB(); | ||
|
|
||
| if ($labels[$i]) { | ||
| db_query('UPDATE stock SET qr_id = :qr_id WHERE id = :id', ['id' => $labels[$i], 'qr_id' => $id]); |
Member
There was a problem hiding this comment.
@pylipp could we change it that the now timestamp matches the now timestamp in the history message?
Contributor
Author
There was a problem hiding this comment.
This would be a refactoring of the simpleBulkSaveChangeHistory function, I'd move it to a separate PR.
Because this function is used in four places, most with UPDATE modified = NOW() before.
HaGuesto
approved these changes
Jan 21, 2026
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
https://trello.com/c/4Auh4PGg