Skip to content

Conversation

@arjankowski
Copy link
Contributor

@arjankowski arjankowski commented Dec 29, 2025

This PR configures PowerShell to use UTF-8 output encoding to resolve character rendering issues on Windows.
While PowerShell 7 already defaults to Unicode (UTF-8), legacy version 5.1 uses the OEM United States code page, which frequently misinterprets non-ASCII data from the Box CLI.

This fix ensures that international characters display correctly in older environments while maintaining a consistent experience across all platforms.

@congminh1254
Copy link
Member

@copilot Why this change needed? Will it break the script usage in any other platform like MacOS / Linux?

Copy link
Contributor

Copilot AI commented Dec 29, 2025

@congminh1254 I've opened a new pull request, #614, to work on those changes. Once the pull request is ready, I'll request review from you.

@coveralls
Copy link

Pull Request Test Coverage Report for Build 20574836248

Details

  • 0 of 0 changed or added relevant lines in 0 files are covered.
  • 1 unchanged line in 1 file lost coverage.
  • Overall coverage decreased (-0.04%) to 85.545%

Files with Coverage Reduction New Missed Lines %
src/commands/files/zip.js 1 81.03%
Totals Coverage Status
Change from base Build 19635186348: -0.04%
Covered Lines: 4733
Relevant Lines: 5333

💛 - Coveralls

Copy link

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Copilot reviewed 7 out of 7 changed files in this pull request and generated no comments.


💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

@congminh1254
Copy link
Member

Copilot saying that it's good to go 🥇

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants