Skip to content

Handle invalid search terms #40

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
blocknotes merged 2 commits into from
Apr 20, 2025
Merged

Handle invalid search terms #40

blocknotes merged 2 commits into from
Apr 20, 2025

Conversation

@blocknotes
Copy link
Owner

@blocknotes blocknotes commented Apr 20, 2025 •
edited
Loading

Replace PR: #34

The original idea is good but I preferred to address some small changes:

  • rebase;
  • address linter offenses;
  • simplify the flash message error logic;
  • improve the callback.

@blocknotes blocknotes self-assigned this Apr 20, 2025
@blocknotes blocknotes force-pushed the handle_invalid_search_terms branch 2 times, most recently from 615b1e4 to 301a335 Compare April 20, 2025 08:17
@blocknotes blocknotes force-pushed the handle_invalid_search_terms branch from 301a335 to 0753d5b Compare April 20, 2025 16:21
@blocknotes blocknotes force-pushed the handle_invalid_search_terms branch from 0753d5b to f5943c1 Compare April 20, 2025 20:22
@blocknotes blocknotes marked this pull request as ready for review April 20, 2025 20:23
@blocknotes blocknotes merged commit 10ce78b into main Apr 20, 2025
10 checks passed
@blocknotes blocknotes deleted the handle_invalid_search_terms branch April 20, 2025 20:24
@blocknotes blocknotes mentioned this pull request Apr 20, 2025
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

@blocknotes blocknotes

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@blocknotes @goosys