Skip to content

Conversation

@DylanVanBrugghe
Copy link

  • Added 99-xdebug.ini for debugging using Xdebug
  • Added price scraping possibility. (Currently without currency, as this would require a lot of rework)

@DylanVanBrugghe DylanVanBrugghe changed the title Added price scraping, resolves benjaminjonard/koillection#1213 Added price scraping, resolves #1213 Dec 29, 2025
@DylanVanBrugghe DylanVanBrugghe changed the title Added price scraping, resolves #1213 Resolves #1213 Dec 29, 2025
@DylanVanBrugghe DylanVanBrugghe changed the title Resolves #1213 Added price scraping, resolves #1213 Dec 29, 2025
@DylanVanBrugghe
Copy link
Author

Resolves #1213

@benjaminjonard
Copy link
Owner

Hello, thanks for this PR. I think we shouldn't use the pricePath property as is was meant to be used by wish scrappers only, it would be better to use dataPaths like other item data, especially if we add currency support.

I'll have a look later, I want to update to the newest versions of Symfony, PHP and switch to a new docker image before merging new changes.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants