Skip to content

Conversation

@take-cheeze
Copy link

@take-cheeze take-cheeze commented Dec 24, 2025

@bellard
Copy link
Owner

bellard commented Dec 24, 2025

OK for the actions but without the Makefile change (it is no longer required as -Werror was removed).

@take-cheeze
Copy link
Author

@bellard Thank you for reviewing. I've resolved the conflict and removed Makefile change

@rurban
Copy link

rurban commented Dec 25, 2025

Without asan? Or at least valgrind

@bellard
Copy link
Owner

bellard commented Dec 29, 2025

It would be interesting to add other tests such as:

  • "make test" in 32 bit (CONFIG_X86_32=y)
  • "make test" with mac OS build
  • "make test" with ASAN
  • ARM 32 bit "make test" using either cross tools (arm-linux-gcc + qemu to run make test) or in an ARM distribution (as in the QuickJS CI).

@take-cheeze
Copy link
Author

Yeah, having more test environment seems to be interesting.
Though it will need many changes to Makefile and I'd like to have a base line CI first and add other cases later.
https://github.com/bellard/quickjs/blob/master/.github/workflows/ci.yml have many configurations

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants