Skip to content

Conversation

@b-yogesh
Copy link
Collaborator

@b-yogesh b-yogesh commented Apr 2, 2025

This PR addresses a part of xcube-dev/xcube#1134 issue.

One of the TODOs required making these charts dynamically resizable when the split pane's width changes, this PR implements that for Vega Charts.

It also fixes the dependency problem that occurred due to new Vega releases.

@b-yogesh b-yogesh self-assigned this Apr 2, 2025
@codecov
Copy link

codecov bot commented Apr 4, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 92.70%. Comparing base (7f34d9e) to head (f55c324).
Report is 1 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main     #121      +/-   ##
==========================================
+ Coverage   92.64%   92.70%   +0.06%     
==========================================
  Files          85       86       +1     
  Lines        1481     1495      +14     
  Branches      222      224       +2     
==========================================
+ Hits         1372     1386      +14     
  Misses         91       91              
  Partials       18       18              
Flag Coverage Δ
frontend 84.84% <100.00%> (+0.30%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@b-yogesh b-yogesh removed their assignment Apr 4, 2025
@b-yogesh b-yogesh marked this pull request as ready for review April 4, 2025 14:00
Copy link
Member

@forman forman left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great, thanks!

@forman forman removed the request for review from AliceBalfanz April 14, 2025 13:54
@b-yogesh b-yogesh merged commit 96c1ef3 into main Apr 14, 2025
5 checks passed
@b-yogesh b-yogesh deleted the yogesh-xxx-add_dynamic_resizing_for_vega_charts branch April 14, 2025 14:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants