-
Notifications
You must be signed in to change notification settings - Fork 262
Move ATI Analytics Tests to Article Page #13576
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Move ATI Analytics Tests to Article Page #13576
Conversation
| assertPageView, | ||
| assertArticleLiteSiteLinkComponentView, | ||
| assertArticleLiteSiteLinkComponentClick, | ||
| assertFeaturesAnalysisComponentView, | ||
| assertFeaturesAnalysisComponentClick, | ||
| assertMostReadComponentView, | ||
| assertMostReadComponentClick, | ||
| assertPodcastPromoComponentView, | ||
| assertPodcastPromoComponentClick, | ||
| assertRelatedTopicsComponentView, | ||
| assertRelatedTopicsComponentClick, | ||
| assertRelatedContentComponentView, | ||
| assertRelatedContentComponentClick, | ||
| assertTopStoriesComponentView, | ||
| assertTopStoriesComponentClick, |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Do some of these need excluded if its the Lite version being requested?
I can see we have this logic currently in the specialFeatures/atiAnalytics/ tests:
simorgh/ws-nextjs-app/cypress/e2e/specialFeatures/atiAnalytics/index.cy.ts
Lines 296 to 309 in 0ee15e3
| const liteTestSuites = canonicalTestSuites | |
| .filter(({ path }) => path !== '/ws/languages') | |
| .map(testSuite => { | |
| const excludedLiteTests = [ | |
| assertPodcastPromoComponentView, // Podcast promo removed from lite article pages | |
| assertPodcastPromoComponentClick, // Podcast promo removed from lite article pages | |
| assertDropdownNavigationComponentView, // Dropdown navigation removed from all pages, as it requires JS | |
| assertDropdownNavigationComponentClick, // Dropdown navigation removed from all pages, as it requires JS | |
| assertSocialEmbedComponentView, // Social embeds removed from lite article pages | |
| assertSocialEmbedComponentClick, // Social embeds removed from lite article pages | |
| assertArticleLiteSiteLinkComponentView, // Lite Site Link only displayed on canonical article pages | |
| assertArticleLiteSiteLinkComponentClick, // Lite Site Link only displayed on canonical article pages | |
| assertFeaturesAnalysisComponentClick, // Features & Analysis component click event test not working on lite pages | |
| ]; |
…efactorATIAnalyticsTestsForArticlesPage
…ps://github.com/bbc/simorgh into WS-954-RefactorATIAnalyticsTestsForArticlesPage
…efactorATIAnalyticsTestsForArticlesPage
…efactorATIAnalyticsTestsForArticlesPage
…efactorATIAnalyticsTestsForArticlesPage
Resolves JIRA: Refactor ATI Analytics tests: Articles
Summary
A very high-level summary of easily-reproducible changes that can be understood by non-devs, and why these changes where made.
Code changes
Developer Checklist
Testing
Ready-For-Test, Local)Ready-For-Test, Test)Ready-For-Test, Preview)Ready-For-Test, Live)Additional Testing Steps
Useful Links