Skip to content

Conversation

@MeriemMechri
Copy link
Contributor

Resolves JIRA: Refactor ATI Analytics tests: Articles
Summary

A very high-level summary of easily-reproducible changes that can be understood by non-devs, and why these changes where made.

Code changes

  • A bullet point list of key code changes that have been made.

Developer Checklist

  • UX
    • UX Criteria met (visual UX & screenreader UX)
  • Accessibility
    • Accessibility Acceptance Criteria met
    • Accessibility swarm completed
    • Component Health updated
    • P1 accessibility bugs resolved
    • P2/P3 accessibility bugs planned (if not resolved)
  • Security
    • Security issues addressed
    • Threat Model updated
  • Documentation
    • Docs updated (runbook, READMEs)
  • Testing
    • Feature tested on relevant environments
  • Comms
    • Relevant parties notified of changes

Testing

  • Manual Testing required?
    • Local (Ready-For-Test, Local)
    • Test (Ready-For-Test, Test)
    • Preview (Ready-For-Test, Preview)
    • Live (Ready-For-Test, Live)
  • Manual Testing complete?
    • Local
    • Test
    • Preview
    • Live

Additional Testing Steps

  1. List the steps required to test this PR.

Useful Links

@MeriemMechri MeriemMechri self-assigned this Dec 30, 2025
@MeriemMechri MeriemMechri marked this pull request as ready for review December 31, 2025 10:18
Comment on lines +312 to +326
assertPageView,
assertArticleLiteSiteLinkComponentView,
assertArticleLiteSiteLinkComponentClick,
assertFeaturesAnalysisComponentView,
assertFeaturesAnalysisComponentClick,
assertMostReadComponentView,
assertMostReadComponentClick,
assertPodcastPromoComponentView,
assertPodcastPromoComponentClick,
assertRelatedTopicsComponentView,
assertRelatedTopicsComponentClick,
assertRelatedContentComponentView,
assertRelatedContentComponentClick,
assertTopStoriesComponentView,
assertTopStoriesComponentClick,
Copy link
Contributor

@amoore108 amoore108 Dec 31, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Do some of these need excluded if its the Lite version being requested?

I can see we have this logic currently in the specialFeatures/atiAnalytics/ tests:

const liteTestSuites = canonicalTestSuites
.filter(({ path }) => path !== '/ws/languages')
.map(testSuite => {
const excludedLiteTests = [
assertPodcastPromoComponentView, // Podcast promo removed from lite article pages
assertPodcastPromoComponentClick, // Podcast promo removed from lite article pages
assertDropdownNavigationComponentView, // Dropdown navigation removed from all pages, as it requires JS
assertDropdownNavigationComponentClick, // Dropdown navigation removed from all pages, as it requires JS
assertSocialEmbedComponentView, // Social embeds removed from lite article pages
assertSocialEmbedComponentClick, // Social embeds removed from lite article pages
assertArticleLiteSiteLinkComponentView, // Lite Site Link only displayed on canonical article pages
assertArticleLiteSiteLinkComponentClick, // Lite Site Link only displayed on canonical article pages
assertFeaturesAnalysisComponentClick, // Features & Analysis component click event test not working on lite pages
];

@MeriemMechri MeriemMechri requested a review from amoore108 January 6, 2026 11:29
…efactorATIAnalyticsTestsForArticlesPage
@MeriemMechri MeriemMechri merged commit ef146c9 into latest Jan 6, 2026
13 checks passed
@MeriemMechri MeriemMechri deleted the WS-954-RefactorATIAnalyticsTestsForArticlesPage branch January 6, 2026 15:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants