Fix clang-scan-deps PATH lookup and lld detection on macOS #563
+24
−9
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
This PR fixes two related toolchain configuration issues:
1. clang-scan-deps PATH lookup (fixes #553)
Problem:
clang-scan-depspath was hardcoded by assuming it's in the same directory as the compiler:Solution: Use PATH lookup via
which()first, with fallback to the compiler directory for backward compatibility.2. lld path detection on macOS (fixes #499)
Problem:
_find_linker_path()used the last quoted path line from stderr:When lld emits warnings (e.g.,
ld64.lld: warning: directory not found for option -L/usr/local/lib), the warning appears after the linker invocation, causing the detection to fail.Solution: Look for the specific linker invocation line by matching linker patterns (
ld.lld,ld64.lld,ld.gold,gold) instead of blindly using the last line.Test plan