Fix Argument 1: cannot convert 'System.Globalization.CultureIn… for Unity 6000.3+ #267
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
RamiAhmed
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
As explained in #266, the package does not compile in Unity 6.3 LTS due to
SceneHandle.ToString(CultureInfo.InvariantCulture)no longer being valid.However, the proposed fix in #266 is incorrect. It passes
CultureInfo.InvariantCulture.ToString()(which returns a string like "Invariant Language (Invariant Country)") as a parameter toSceneHandle.ToString(). This compiles but is semantically wrong - it's not actually using the culture for formatting.The correct fix is to call
SceneHandle.ToString()without parameters, asSceneHandledoes not implementIFormattableand does not support culture-specific formatting. I've used preprocessor directives to apply this fix only to Unity 6000.3+ to maintain backwards compatibility with the existing implementation.Tested on Unity 6.3 LTS.