GOVERNANCE: Update Reviewer role and process #260
Conversation
There was a problem hiding this comment.
Pull request overview
This PR updates the Backstage governance documentation to introduce a formal Reviewer role and refine the pull request review process. The changes establish clearer pathways for community members to contribute through code reviews and streamline the review coordination process by referencing a new REVIEWING.md document in the main Backstage repository.
Changes:
- Introduced formal Reviewer role with defined responsibilities, requirements, and privileges
- Added reviewer request issue template for joining the
@backstage/reviewersteam - Simplified Pull Request Management documentation to reference the new REVIEWING.md process
Reviewed changes
Copilot reviewed 4 out of 4 changed files in this pull request and generated 1 comment.
| File | Description |
|---|---|
| GOVERNANCE.md | Expands the Reviewer role section with detailed requirements, privileges, and a self-service onboarding process |
| .github/ISSUE_TEMPLATE/reviewer.yaml | Adds a new issue template for requesting Reviewer status with validation for organization membership |
| project-areas/Maintainer-Guidance.md | Simplifies Pull Request Management section by removing detailed process documentation and referencing REVIEWING.md |
| project-areas/core/README.md | Updates Pull Request Reviews section to reference REVIEWING.md and focus on high-priority review coordination |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>
| every week. | ||
| Project area maintainers in the main Backstage repository are responsible for reviewing pull requests towards their area, as outlined in [REVIEWING.md](https://github.com/backstage/backstage/blob/master/REVIEWING.md). | ||
|
|
||
| Project area maintainers in other repositories are responsible for defining their own ways of working for pull request reviews. |
There was a problem hiding this comment.
Do we want to point to the Community Plugins repo as an example of where the process is different? If we do then I would point them towards this: https://github.com/backstage/community-plugins/blob/main/docs/plugin-maintainers-guide.md
freben
changed the title
Governance updates for backstage/backstage#32370, let's keep discussion around the process in that PR and just focusing on the specifics of these updates here.