feat: Support Project CRD #331
Conversation
ack-prow
bot
added
the
do-not-merge/work-in-progress
|
Skipping CI for Draft Pull Request. |
ack-prow
bot
removed
the
do-not-merge/work-in-progress
michaelhtm
left a comment
michaelhtm
left a comment
There was a problem hiding this comment.
Thanks @sirutBuasai
left a few comments below.
Can we also have e2e tests?
|
@sirutBuasai: The following test failed, say
Full PR test history. Your PR dashboard. DetailsInstructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here. |
michaelhtm
left a comment
michaelhtm
left a comment
There was a problem hiding this comment.
Thanks again @sirutBuasai
left one question below, but everything else lgtm
| logging.error( | ||
| f"ARN for this resource is None, resource status is: {resource['status']}" | ||
| ) | ||
| assert k8s.get_resource_arn(resource) is not None |
There was a problem hiding this comment.
would the resource have an ARN even if it fails to create?
There was a problem hiding this comment.
Yes, so that was part of the test that checks that the controller is functioning actually. If the controller fails to even call the API, it won't generate the ARN.
The create fail test is moreso a test where the resource is created, but during the creation process, it wasn't able to talk to ServiceCatalogue to create a git repo, and so it fails.
|
/lgtm |
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: michaelhtm, sirutBuasai The full list of commands accepted by this bot can be found here. The pull request process is described here DetailsNeeds approval from an approver in each of these files:
Approvers can indicate their approval by writing |
2 participants
Issue #, if available:
Description of changes:
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.