fix: missing immutable setup under type_def

[justin0u0]

This PR fixes an issue where the is_immutable configuration was not being applied to nested fields (e.g. HealthCheckConfig.Type).

Verified using route53-controller. The generator now correctly applies validation markers to immutable nested fields in HealthCheckConfig, resulting in the correct x-kubernetes-validations in the output CRD.

diff --git a/apis/v1alpha1/types.go b/apis/v1alpha1/types.go
index afc17d0..e25f221 100644
--- a/apis/v1alpha1/types.go
+++ b/apis/v1alpha1/types.go
@@ -148,14 +148,18 @@ type HealthCheckConfig struct {
 	IPAddress                    *string          `json:"ipAddress,omitempty"`
 	InsufficientDataHealthStatus *string          `json:"insufficientDataHealthStatus,omitempty"`
 	Inverted                     *bool            `json:"inverted,omitempty"`
-	MeasureLatency               *bool            `json:"measureLatency,omitempty"`
-	Port                         *int64           `json:"port,omitempty"`
-	Regions                      []*string        `json:"regions,omitempty"`
-	RequestInterval              *int64           `json:"requestInterval,omitempty"`
-	ResourcePath                 *string          `json:"resourcePath,omitempty"`
-	RoutingControlARN            *string          `json:"routingControlARN,omitempty"`
-	SearchString                 *string          `json:"searchString,omitempty"`
-	Type                         *string          `json:"type,omitempty"`
+	// +kubebuilder:validation:XValidation:rule="self == oldSelf",message="Value is immutable once set"
+	MeasureLatency *bool     `json:"measureLatency,omitempty"`
+	Port           *int64    `json:"port,omitempty"`
+	Regions        []*string `json:"regions,omitempty"`
+	// +kubebuilder:validation:XValidation:rule="self == oldSelf",message="Value is immutable once set"
+	RequestInterval *int64  `json:"requestInterval,omitempty"`
+	ResourcePath    *string `json:"resourcePath,omitempty"`
+	// +kubebuilder:validation:XValidation:rule="self == oldSelf",message="Value is immutable once set"
+	RoutingControlARN *string `json:"routingControlARN,omitempty"`
+	SearchString      *string `json:"searchString,omitempty"`
+	// +kubebuilder:validation:XValidation:rule="self == oldSelf",message="Value is immutable once set"
+	Type *string `json:"type,omitempty"`
 }
 
 // A complex type that contains the last failure reason as reported by one Amazon
diff --git a/config/crd/bases/route53.services.k8s.aws_healthchecks.yaml b/config/crd/bases/route53.services.k8s.aws_healthchecks.yaml
index ea5e040..d55c176 100644
--- a/config/crd/bases/route53.services.k8s.aws_healthchecks.yaml
+++ b/config/crd/bases/route53.services.k8s.aws_healthchecks.yaml
@@ -82,6 +82,9 @@ spec:
                     type: string
                   measureLatency:
                     type: boolean
+                    x-kubernetes-validations:
+                    - message: Value is immutable once set
+                      rule: self == oldSelf
                   port:
                     format: int64
                     type: integer
@@ -92,14 +95,23 @@ spec:
                   requestInterval:
                     format: int64
                     type: integer
+                    x-kubernetes-validations:
+                    - message: Value is immutable once set
+                      rule: self == oldSelf
                   resourcePath:
                     type: string
                   routingControlARN:
                     type: string
+                    x-kubernetes-validations:
+                    - message: Value is immutable once set
+                      rule: self == oldSelf
                   searchString:
                     type: string
                   type:
                     type: string
+                    x-kubernetes-validations:
+                    - message: Value is immutable once set
+                      rule: self == oldSelf
                 type: object
               tags:
                 description: |-

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.

[ack-prow]

Hi @justin0u0. Thanks for your PR.

I'm waiting for a aws-controllers-k8s member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

[a-hilaly]

Thank you @justin0u0 !

[ack-prow]

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: a-hilaly, justin0u0

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

• OWNERS [a-hilaly]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

[justin0u0]

Hi @a-hilaly, thanks for the review.

Do you need anything from me to get this pull request merged? Thanks!

[a-hilaly]

would it be possible to have some unit tests for this feature? thank you!

[a-hilaly]

/ok-to-test

[a-hilaly]

actually second thoughts not sure we have the mechanics to unit tests generated code via templating :)

[justin0u0]

actually second thoughts not sure we have the mechanics to unit tests generated code via templating :)

Yeah, as far as I know there is no unit testing for the templates for now. And it is difficult to write unit tests for code generation. Maybe we need to introduce snapshot testing?

[ack-prow]

@justin0u0: The following tests failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name	Commit	Details	Required	Rerun command
verify-attribution	5671571	link	false	/test verify-attribution
s3-olm-test	5671571	link	false	/test s3-olm-test

Full PR test history. Your PR dashboard.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

[a-hilaly]

@justin0u0 i think ideally we need one of two things:

• Wrap the template generate and make them generate a string that we can test (and an error instead of panic)
• Move completely out of templating and continue using Go line by line generation approach everywhere

[a-hilaly]

/test s3-controller-test

[a-hilaly]

Cc @michaelhtm