virtio-win:add vsock svc map info

[leidwang]

ID: 4313,4314,4315

Summary by CodeRabbit

• New Features
  • Added support for VirtioSocket driver component, extending compatibility with available virtio drivers.

_{✏️ Tip: You can customize this high-level summary in your review settings.}

[coderabbitai]

Walkthrough

A new entry for the VirtIO Socket driver ("viosock": "VirtioSocket") is added to the DRIVER_SVC_MAP dictionary in the virtio_win.py utility module. This is a purely additive change that extends the set of recognized virtio service components without modifying existing entries or control flow.

Estimated code review effort

🎯 1 (Trivial) | ⏱️ ~3 minutes

• Verify that the key-value pair "viosock": "VirtioSocket" matches the intended driver mapping convention
• Confirm the entry follows the existing naming pattern established in the dictionary

Pre-merge checks

✅ Passed checks (3 passed)

Check name	Status	Explanation
Description Check	✅ Passed	Check skipped - CodeRabbit’s high-level summary is enabled.
Title check	✅ Passed	The title accurately summarizes the main change: adding a vsock service map entry to DRIVER_SVC_MAP in the virtio-win module.
Docstring Coverage	✅ Passed	No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check.

---

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

• X
• Mastodon
• Reddit
• LinkedIn

_{Comment @coderabbitai help to get the list of available commands and usage tips.}

[coderabbitai]

Actionable comments posted: 1

📜 Review details

Configuration used: CodeRabbit UI

Review profile: CHILL

Plan: Pro

📥 Commits

Reviewing files that changed from the base of the PR and between 3c00fa8 and 8c3e5c6.

📒 Files selected for processing (1)

• virttest/utils_windows/virtio_win.py (1 hunks)

⏰ Context from checks skipped due to timeout of 90000ms. You can increase the timeout in your CodeRabbit configuration to a maximum of 15 minutes (900000ms). (1)

• GitHub Check: Static checks

[coderabbitai]

⚠️ Potential issue | 🟡 Minor

🧩 Analysis chain

🏁 Script executed:

#!/bin/bash
# Description: Find all usages of DRIVER_SVC_MAP and references to viosock

# Find usages of DRIVER_SVC_MAP
echo "=== Usages of DRIVER_SVC_MAP ==="
rg -n -C3 "DRIVER_SVC_MAP" --type=py

# Find any existing references to viosock or VirtioSocket
echo -e "\n=== Existing references to viosock ==="
rg -n -i "viosock|virtiosocket" --type=py

Repository: avocado-framework/avocado-vt

Length of output: 1362

---

🏁 Script executed:

#!/bin/bash
# Check for documentation, tests, or comments that reference viosock service

# Look for viosock in test files and documentation
echo "=== Search for viosock in test files ==="
rg -n "viosock" -A 5 -B 5 --type=py

# Look for service name references or Windows driver info
echo -e "\n=== Look for SERVICE or Windows driver patterns ==="
rg -n "VirtioSocket|VirtRng|VirtioSerial|VirtioFsDrv|VirtioInput" --type=py

# Check git history or comments about viosock
echo -e "\n=== Check all files mentioning virtio or svc ==="
rg -n "viosock|VirtioSocket" . --type=py -A 2 -B 2

Repository: avocado-framework/avocado-vt

Length of output: 4661

---

🏁 Script executed:

#!/bin/bash
# Look for documentation or comments about Windows service names

# Check README or documentation files
echo "=== Look for README or documentation files ==="
find . -type f \( -name "README*" -o -name "*.md" -o -name "*.txt" -o -name "*.rst" \) | head -20

# Check for any comments or docstrings mentioning viosock
echo -e "\n=== Check for comments or docstrings in virtio_win.py ==="
head -100 virttest/utils_windows/virtio_win.py

# Look for QEMU or Windows documentation references
echo -e "\n=== Look for Windows driver or service references ==="
rg -n "service|SERVICE|Service" virttest/utils_windows/virtio_win.py -A 3 -B 3

# Check for any configuration or mapping files
echo -e "\n=== Check for config files that might reference service names ==="
find . -name "*.cfg" -o -name "*.conf" -o -name "*.yaml" -o -name "*.json" | grep -v node_modules | head -20

Repository: avocado-framework/avocado-vt

Length of output: 4108

---

🏁 Script executed:

#!/bin/bash
# Check the Windows virtio installation documentation
cat ./docs/source/InstallWinVirtio.rst | head -200

Repository: avocado-framework/avocado-vt

Length of output: 8190

---

LGTM! Verify the Windows service name for viosock.

The addition follows the existing pattern correctly and is backward compatible. The code in utils_test/qemu/__init__.py safely handles new entries with a fallback pattern, so this new entry won't cause issues. However, please verify that "VirtioSocket" is the correct Windows service name for the viosock driver according to official QEMU/Windows virtio driver documentation.

🤖 Prompt for AI Agents

In virttest/utils_windows/virtio_win.py around line 23, the mapping adds
"viosock": "VirtioSocket" but the review requests you verify the actual Windows
service name for the viosock driver; confirm the official QEMU/Windows virtio
driver docs or inspect a Windows guest with the driver installed to determine
the correct service display/name (e.g., "viosock" vs "VirtioSocket" or another
exact string) and if different, update this mapping to the exact canonical
service name used by Windows; ensure casing and spacing match the OS service
entry and add a brief inline comment referencing the doc/source you used for
verification.

[leidwang]

Hi @xiagao Could you please review this PR?Thanks.

[xiagao]

LGTM.