Collect all VM disk target device names from dumpxml

[BulaYoungR]

Summary by CodeRabbit

• Refactor
  • Added an internal utility to enumerate virtual machine disk target names from VM configurations.
  • No user-visible behavior, workflows, outputs, or performance impacts.
  • Error handling and logging unchanged; no documentation updates required.

[coderabbitai]

📝 Walkthrough

Walkthrough

Adds a new public helper function get_all_disks_target(vm_name, options="") in virttest/utils_libvirt/libvirt_disk.py that loads a VM XML by vm_name, collects disk target device names (disk.target.dev) from disk devices, and returns them as a list. Returns an empty list if VM XML is None.

Changes

Cohort / File(s)	Summary of Changes
Libvirt disk utilities virttest/utils_libvirt/libvirt_disk.py	Added public helper get_all_disks_target(vm_name, options="") which loads VM XML via VMXML.new_from_dumpxml, extracts disk.target.dev values from disk devices (safely handling missing targets), logs discovered targets, and returns the list; no existing behaviors modified.

Estimated code review effort

🎯 2 (Simple) | ⏱️ ~10 minutes

Pre-merge checks

✅ Passed checks (3 passed)

Check name	Status	Explanation
Description Check	✅ Passed	Check skipped - CodeRabbit’s high-level summary is enabled.
Docstring Coverage	✅ Passed	Docstring coverage is 100.00% which is sufficient. The required threshold is 80.00%.
Title Check	✅ Passed	The pull request title "Collect all VM disk target device names from dumpxml" accurately describes the main change in the changeset, which is the addition of a new public helper function get_all_disks_target() that retrieves disk target device names from VM XML via dumpxml. The title is clear, specific, and concise without vague terms or unnecessary noise, making it easy for teammates to understand the primary change at a glance.

---

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

• X
• Mastodon
• Reddit
• LinkedIn

_{Comment @coderabbitai help to get the list of available commands and usage tips.}

[coderabbitai]

Actionable comments posted: 1

🧹 Nitpick comments (1)

virttest/utils_libvirt/libvirt_disk.py (1)

166-169: Optional: align with existing device access pattern

Elsewhere in this module, devices are accessed via vmxml.devices.by_device_tag("disk"). Consider using that for consistency with get_mirror_part_in_xml(). Functionality is the same.

📜 Review details

Configuration used: CodeRabbit UI

Review profile: CHILL

Plan: Pro

💡 Knowledge Base configuration:

• MCP integration is disabled by default for public repositories
• Jira integration is disabled
• Linear integration is disabled

You can enable these sources in your CodeRabbit configuration.

📥 Commits

Reviewing files that changed from the base of the PR and between 5308b66 and 9f40114.

📒 Files selected for processing (1)

• virttest/utils_libvirt/libvirt_disk.py (1 hunks)

🧰 Additional context used

🧬 Code graph analysis (1)

virttest/utils_libvirt/libvirt_disk.py (1)

virttest/libvirt_xml/vm_xml.py (4)

• VMXML (753-2082)
• new_from_dumpxml (788-803)
• get_devices (550-565)
• append (40-43)

🪛 Ruff (0.12.2)

virttest/utils_libvirt/libvirt_disk.py

165-165: Undefined name vm_name

(F821)

🔇 Additional comments (1)

virttest/utils_libvirt/libvirt_disk.py (1)

163-171: No callers found for _all_disk_targets(); ignore signature‐break concern.

Likely an incorrect or invalid review comment.

[dzhengfy]

@BulaYoungR please check https://github.com/avocado-framework/avocado-vt/actions/runs/18555530700/job/52993748304?pr=4231 for the CI failure