Skip to content

Conversation

@cliping
Copy link
Contributor

@cliping cliping commented Aug 5, 2025

Summary by CodeRabbit

  • New Features
    • NFS mount source and export options now automatically adjust based on the system's mode, providing improved compatibility with systems running in image mode.

@coderabbitai
Copy link

coderabbitai bot commented Aug 5, 2025

Important

Review skipped

Draft detected.

Please check the settings in the CodeRabbit UI or the .coderabbit.yaml file in this repository. To trigger a single review, invoke the @coderabbitai review command.

You can disable this status message by setting the reviews.review_status to false in the CodeRabbit configuration file.

📝 Walkthrough

Walkthrough

A new function, is_image_mode(), was introduced in virttest/nfs.py to detect if the system is running in image mode using the rpm-ostree status command. The Nfs class constructor was updated to conditionally set mount_src and export_options based on the detected system mode.

Changes

Cohort / File(s) Change Summary
Image Mode Detection & NFS Adjustment
virttest/nfs.py
Added is_image_mode() function to check system mode via rpm-ostree status. Modified Nfs.__init__ to set mount_src and export_options based on image mode status, with logging for each case.

Estimated code review effort

🎯 2 (Simple) | ⏱️ ~7 minutes


Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands and usage tips.

@cliping cliping marked this pull request as draft August 5, 2025 02:49
@cliping cliping force-pushed the fix-nfs-mount branch 2 times, most recently from be17eae to d43380d Compare August 5, 2025 04:49
Signed-off-by: lcheng <lcheng@redhat.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant