Feature - loadWebVTTSubtitlesAtURL #1
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
allenlinli
force-pushed
the
feature/WebVttToSRT
branch
from
5207e1f to
80be308
Compare
Contributor
Author
|
Hi @autresphere I wonder if this PR is ok now? |
Owner
|
Hi @allenlinli, this looks really good, thanks a lot! |
allenlinli
changed the title
Contributor
Author
|
I probably cannot fix Travis CI when I on work, I want to have a look when I am off work. |
allenlinli
force-pushed
the
feature/WebVttToSRT
branch
from
80be308 to
6a280fd
Compare
allenlinli
force-pushed
the
feature/WebVttToSRT
branch
from
6a280fd to
1778337
Compare
Pod install
…ingWithPattern:withTemplate:`
allenlinli
force-pushed
the
feature/WebVttToSRT
branch
from
1778337 to
cef9662
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add new function
- (void)loadWebVTTSubtitlesAtURL:(NSURL *)url error:(NSError **)error, so ASBPlayerSubtitling.h accepts WebVTT.Re-install pod to make project compilable.