[DAS 379] - Fix for Authentication and Updated SdkManager dependencies. #15
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Keep Main branch updated with Development
Snyk has created this PR to upgrade ch.qos.logback:logback-classic from 1.4.12 to 1.5.21. See this package in maven: ch.qos.logback:logback-classic See this project in Snyk: https://app.snyk.io/org/aps-sdk/project/3b347854-1989-481d-8760-53afcb6147d0?utm_source=github&utm_medium=referral&page=upgrade-pr
Snyk has created this PR to upgrade org.slf4j:slf4j-api from 2.0.9 to 2.0.17. See this package in maven: org.slf4j:slf4j-api See this project in Snyk: https://app.snyk.io/org/aps-sdk/project/3b347854-1989-481d-8760-53afcb6147d0?utm_source=github&utm_medium=referral&page=upgrade-pr
…o 5.5.1 Snyk has created this PR to upgrade org.apache.httpcomponents.client5:httpclient5 from 5.5 to 5.5.1. See this package in maven: org.apache.httpcomponents.client5:httpclient5 See this project in Snyk: https://app.snyk.io/org/aps-sdk/project/3b347854-1989-481d-8760-53afcb6147d0?utm_source=github&utm_medium=referral&page=upgrade-pr
…5440754fdcc61d38bda47c8707fd111 [Snyk] Upgrade ch.qos.logback:logback-classic from 1.4.12 to 1.5.21
…de-420bdef401a7ee1c0553754c154e1a77
…20bdef401a7ee1c0553754c154e1a77 [Snyk] Upgrade org.slf4j:slf4j-api from 2.0.9 to 2.0.17
…01131aa9537075ea04465e7e056f405 [Snyk] Upgrade org.apache.httpcomponents.client5:httpclient5 from 5.5 to 5.5.1
There was a problem hiding this comment.
Pull request overview
This pull request addresses authentication token expiration handling and updates SDK dependencies to version 0.1.1-beta. The key changes include fixing the token expiration calculation by using proper epoch seconds representation and upgrading several core dependencies.
- Changed
expiresAtfield type fromIntegertoLongto properly handle epoch seconds timestamps - Implemented automatic
expiresAtcalculation insetExpiresInmethod based on current time - Updated authentication SDK and sdkmanager dependencies from
0.1.0-betato0.1.1-betawith upgraded httpcomponents, slf4j, and logback versions
Reviewed changes
Copilot reviewed 5 out of 5 changed files in this pull request and generated 2 comments.
Show a summary per file
| File | Description |
|---|---|
| authentication/pom.xml | Bumped authentication SDK version to 0.1.1-beta and updated sdkmanager dependency |
| authentication/src/main/java/com/autodesk/aps/authentication/model/TwoLeggedToken.java | Changed expiresAt from Integer to Long and added auto-calculation logic in setExpiresIn |
| samples/pom.xml | Updated authentication SDK dependency version to 0.1.1-beta |
| samples/src/main/java/com/autodesk/aps/samples/AuthenticationSample.java | Fixed token expiration display to use expiresAt with epoch seconds conversion |
| sdkmanager/pom.xml | Bumped version to 0.1.1-beta and upgraded httpcomponents, slf4j, and logback dependencies |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This pull request updates the authentication SDK and its dependencies, and improves the handling of token expiration in the
TwoLeggedTokenmodel. The most important changes are grouped below:Authentication SDK & Dependency Updates:
0.1.0-betato0.1.1-betainauthentication/pom.xml,samples/pom.xml, andsdkmanager/pom.xml. [1] [2] [3] [4]sdkmanager/pom.xml:httpcomponentsto5.5.1slf4jto2.0.17logbackto1.5.21Token Expiration Handling Improvements:
expiresAtfield inTwoLeggedTokenfromIntegertoLongto better represent epoch seconds, and updated related getter, setter, and builder methods. [1] [2]setExpiresInto automatically setexpiresAtbased on the current time and theexpiresInvalue usingInstant.now().getEpochSecond().AuthenticationSample.javato correctly convert and display theexpiresAtvalue as a local date/time usingInstant.ofEpochSecond.Minor Code Cleanups:
AuthenticationSample.java.java.time.InstantinTwoLeggedToken.java.