Skip to content

Conversation

@hagenw
Copy link
Member

@hagenw hagenw commented Oct 16, 2025

Update to latest ruff and codespell versions in pre-commit.

Summary by Sourcery

Bump ruff and codespell to their latest versions in pre-commit configuration and apply resulting automated fixes for f-string quoting and test message formatting.

Enhancements:

  • Update ruff pre-commit hook to v0.13.3
  • Update codespell pre-commit hook to v2.4.1
  • Normalize f-string quoting in core code and benchmark plots
  • Simplify redundant string concatenation in test error messages

@sourcery-ai
Copy link

sourcery-ai bot commented Oct 16, 2025

Reviewer's guide (collapsed on small PRs)

Reviewer's Guide

This PR updates the pre-commit configuration to use the latest ruff and codespell releases and enforces consistent string quoting in f-strings and literals across the codebase.

Class diagram for string quoting changes in io.py and plot.py

classDiagram
  class write {
    +write(...)
    - if bit_depth not in bit_depths: raise RuntimeError("... " + ", ".join([str(b) for b in bit_depths]) + " ...")
  }
  class plot {
    +plot(...)
    - g.savefig("results/benchmark_" + "-".join(exts) + "_" + package + ".png")
  }
Loading

File-Level Changes

Change Details Files
Update pre-commit hook versions
  • Bump ruff rev from v0.7.0 to v0.13.3
  • Bump codespell rev from v2.3.0 to v2.4.1
.pre-commit-config.yaml
Standardize string quoting in f-strings and literals
  • Switch inner quotes to double quotes in f-strings for error messages
  • Use consistent double-quoted f-strings in plot save paths
  • Merge adjacent string literals into a single quoted string in tests
audiofile/core/io.py
docs/benchmark/plot.py
tests/test_audiofile.py

Tips and commands

Interacting with Sourcery

  • Trigger a new review: Comment @sourcery-ai review on the pull request.
  • Continue discussions: Reply directly to Sourcery's review comments.
  • Generate a GitHub issue from a review comment: Ask Sourcery to create an
    issue from a review comment by replying to it. You can also reply to a
    review comment with @sourcery-ai issue to create an issue from it.
  • Generate a pull request title: Write @sourcery-ai anywhere in the pull
    request title to generate a title at any time. You can also comment
    @sourcery-ai title on the pull request to (re-)generate the title at any time.
  • Generate a pull request summary: Write @sourcery-ai summary anywhere in
    the pull request body to generate a PR summary at any time exactly where you
    want it. You can also comment @sourcery-ai summary on the pull request to
    (re-)generate the summary at any time.
  • Generate reviewer's guide: Comment @sourcery-ai guide on the pull
    request to (re-)generate the reviewer's guide at any time.
  • Resolve all Sourcery comments: Comment @sourcery-ai resolve on the
    pull request to resolve all Sourcery comments. Useful if you've already
    addressed all the comments and don't want to see them anymore.
  • Dismiss all Sourcery reviews: Comment @sourcery-ai dismiss on the pull
    request to dismiss all existing Sourcery reviews. Especially useful if you
    want to start fresh with a new review - don't forget to comment
    @sourcery-ai review to trigger a new review!

Customizing Your Experience

Access your dashboard to:

  • Enable or disable review features such as the Sourcery-generated pull request
    summary, the reviewer's guide, and others.
  • Change the review language.
  • Add, remove or edit custom review instructions.
  • Adjust other review settings.

Getting Help

Copy link

@sourcery-ai sourcery-ai bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hey there - I've reviewed your changes and they look great!


Sourcery is free for open source - if you like our reviews please consider sharing them ✨
Help me be more useful! Please click 👍 or 👎 on each comment and I'll use the feedback to improve your reviews.

@hagenw hagenw merged commit a8e0ddf into main Oct 16, 2025
35 checks passed
@hagenw hagenw deleted the update-pre-commit branch October 16, 2025 10:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants