-
-
Notifications
You must be signed in to change notification settings - Fork 308
feat(cli): add --compile flag to generate fromTemplate command #1979
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: master
Are you sure you want to change the base?
Conversation
🦋 Changeset detectedLatest commit: 3e6a10b The changes in this PR will be included in the next version bump. This PR includes changesets to release 1 package
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Welcome to AsyncAPI. Thanks a lot for creating your first pull request. Please check out our contributors guide useful for opening a pull request.
Keep in mind there are also other channels you can use to interact with AsyncAPI community. For more details check out this issue.
|
/u |
|
|
Hi @AayushSaini101, I assume /u was meant to trigger a bot update? It seems it didn't pick it up, so I can merge the latest master manually to ensure the branch is up to date. Let me know if you'd like me to proceed with that! |
|
i don't think so as of now we require the changeset cc: @Shurtu-gal |
@AayushSaini101 , Should I remove the changeset, or is there a specific format issue with the one in commit fffc7e9? Happy to adjust as needed. |



Description
This PR enables the
--compileflag for thegenerate fromTemplatecommand, allowing users to opt-out of template compilation (e.g.,--no-compile).Fixes #1829
Changes
compileboolean flag tosharedFlags.ts(default:true).compileoption toBaseGeneratorCommand.tsoptions builder.fromTemplate.test.tsto verify the--no-compileflag is accepted without errors.Verification
npm test -- test/commands/generate/fromTemplate.test.ts