[WIP] Cleanup firmware #16
Draft
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
from now on all constants related to physical hardware tshould be defined here. once I add write some common functions for "libarvp" their prototypes will be placed in arvp/arvp.h. only this file should be included, never auri.h or future arctos.h. for now -DAURI was added to common flags and this won't need to be changed until arctos starts diverging from auri.
- batteryStatus.hpp - pressureStatus.hpp this board controls the front light and the dopper servos it doesn't need to know about battery or pressure status. - publisher.hpp nothing useful was being published so that was deleted. when I rewrite I will see if there is anything that should be published. - serialCommand.hpp this is not the appropriate place for a serial interface so that was deleted. it can be rewritten elsewhere if needed (I don't think it is)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I'm opening this for easier discussion and review outside of meetings.