feat(alerts): add artist series to initial criteria for artwork-based alerts #13244
Conversation
olerichter00
left a comment
olerichter00
left a comment
There was a problem hiding this comment.
Looks good! 👍
I've just added a comment about potentially limiting the number of artist series.
src/Apps/Artwork/ArtworkApp.tsx
Outdated
| attributionClass { | ||
| internalID | ||
| } | ||
| artistSeriesConnection(first: 20) { |
There was a problem hiding this comment.
I wonder whether it is important and if we should limit the artist series criteria to an overseeable limit to avoid showing up to 20 criteria in the "Create Alert" flow.
There was a problem hiding this comment.
Good eye, I didn't pick that number carefully, I just remembered that the max # of series per artwork was 12(!)
The actual distribution looks like this:
The vast majority 94.5% of works in artist series belong to no more than 2 series.
And if we allow up to 5 series, that covers 99.98%. So I think 5 is a good limit here, with the understanding that a tiny handful of works might not reveal all of their series as initial criteria.
The type of this PR is: Feat
This PR solves ONYX-563
Description
Adds the artwork's artist series to the initial inferred criteria for an alert created for an artwork page.