fix: article styling #13118
Draft
fix: article styling #13118
+22
−3
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
anandaroop
commented
Dec 22, 2025
Comment on lines
+87
to
+93
| li: { | ||
| fontFamily: FONTS.regular, | ||
| color: color("mono100"), | ||
| marginBottom: "1em", | ||
|
|
||
| ...variantStyles, | ||
| }, |
Member
Author
There was a problem hiding this comment.
Something is up with the disc alignment for these li's but I haven't figured it out yet.
brainbicycle
approved these changes
Dec 29, 2025
Contributor
brainbicycle
left a comment
brainbicycle
left a comment
There was a problem hiding this comment.
looks great thank you! I am wondering if there is any way to get ahead of these in the future, that is what usually seems to happen now is someone publishes an article with some elements the app doesn't support well, they see it in the app, file a bug and then we rush to fix it. Is there any way we could review articles for what the expected html spec support is? or codify what the expected support is? or offer previews on app before publishing? I don't necessarily think any of those are worth doing now, just thinking out loud if this keeps being a problem.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR resolves DIAM-246
Description
Some articles include H1s and unordered lists, which are not rendered correctly.
H1s would seem unconventional since they are presumably reserved for article titles, but some articles (example) do make use of them and they are handled appropriately on web. Header styles are adjusted here accordingly, to preserve the relative size relationships between article header and body.
H1(in article body)
UL&
LI(for comparison)
PR Checklist
To the reviewers 👀
Changelog updates
Changelog updates
Cross-platform user-facing changes
iOS user-facing changes
Android user-facing changes
Dev changes
Need help with something? Have a look at our docs, or get in touch with us.