chore(ONYX-2018, ONYX-2015): cleanup AREnableArtworkCardContextMenuIOS, AREnableArtworkCardContextMenuAndroid, AREnableLongPressContextMenuOnboarding #13116
+8
−66
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ContextMenuAndroid, AREnableLongPressContextMenuOnboarding
…xt-menu-ios-feature-flag
Contributor
dblandin
approved these changes
Jan 8, 2026
Member
dblandin
left a comment
dblandin
left a comment
There was a problem hiding this comment.
LGTM overall but left one question regarding an addition that may have snuck in.
| }, | ||
| AREnableLongPressContextMenuOnboarding: { | ||
| description: "Enable long press context menu onboarding", | ||
| AREnableProgressiveOnboardingPriceRangeHome: { |
Member
There was a problem hiding this comment.
question: Is this AREnableProgressiveOnboardingPriceRangeHome addition expected? Doesn't look like it's referenced elsewhere in the codebase.
Member
There was a problem hiding this comment.
Ahh, looks like this flag was removed in #13114 so might just need a rebase before merging to ensure it stays out.
Contributor
Author
There was a problem hiding this comment.
Good catch, yep, it has to go
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR resolves ONYX-2018, ONYX-2015
Description
cleanup AREnableArtworkCardContextMenuIOS, AREnableArtworkCardContextMenuAndroid, AREnableLongPressContextMenuOnboarding
PR Checklist
To the reviewers 👀
Changelog updates
Changelog updates
Cross-platform user-facing changes
iOS user-facing changes
Android user-facing changes
Dev changes
Need help with something? Have a look at our docs, or get in touch with us.