-
Notifications
You must be signed in to change notification settings - Fork 594
feat(MOPRAT-867): Improve keyboard handling across the app #13113
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Conversation
react-native-keyboard-controllerAuthor: Kiryl Ziusko Description: Keyboard manager which works in identical way on both iOS and Android Homepage: https://kirillzyusko.github.io/react-native-keyboard-controller/
|
|
New dependencies added:
|
|||||||||||||||
🎉 Beta Versions Generated (commit:
|
🎉 Beta Versions Generated (commit:
|
|
This is impressive work @MrSltun and is a great wrap for 2025! |
olerichter00
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Great work! 🌟
| name: "react-native", | ||
| importNames: ["Keyboard"], | ||
| message: | ||
| "Please use KeyboardController from 'react-native-keyboard-controller' instead.", |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
nice
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
looks great! ✨ love the more consistent floating buttons, I bet we might even see a small bump in some completion metrics on some of these forms, registrations, my profile additions.
Small request, I think we should keep the habit of RFCs for big dep additions, I don't think this one is controversial at all, seems well supported and a solid UX improvement but would be good to just document the why and the decision via an RFC: #12680 just a couple paragraphs and a link to this PR is plenty.
a85cf6b
…oidingView also, delete MyAccountFieldEditScreen and BillingAddress components since they're not being used anywhere
Replacing the use of KeyboardAvoidingView + ScrollView
by opening the country picker modal from "Next" button on the keyboard
a85cf6b to
e35e390
Compare
dariakoko
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Great work Sultan!
🎉 Beta Versions Generated (commit:
|

This PR resolves MOPRAT-867
Description
This PR updates how we handle the keyboard across the app
Videos
Since these changes cover a lot of places, I only recorded a few areas where the effect is very visible
Old (current) keyboard handling implementation
Videos
keyboard-inquiry-android-before-low.mp4
keyboard-inquiry-ios-before-low.mp4
keyboard-complete-profile-android-before-low.mp4
keyboard-complete-profile-ios-before-low.mp4
keyboard-my-collection-android-before-low.mp4
keyboard-my-collection-ios-before-low.mp4
keyboard-credit-card-android-before-low.mp4
keyboard-credit-card-ios-before-low.mp4
New keyboard handling implementation
Videos
keyboard-inquiry-android-after-low.mp4
keyboard-inquiry-ios-after-low.mp4
keyboard-complete-profile-android-after-low.mp4
keyboard-complete-profile-ios-after-low.mp4
keyboard-my-collection-android-after-low.mp4
keyboard-my-collection-ios-after-low.mp4
keyboard-credit-card-android-after-low.mp4
keyboard-credit-card-ios-after-low.mp4
PR Checklist
To the reviewers 👀
Changelog updates
Changelog updates
Cross-platform user-facing changes
iOS user-facing changes
Android user-facing changes
Dev changes
Need help with something? Have a look at our docs, or get in touch with us.