Skip to content

Conversation

@lilyfromseattle
Copy link
Contributor

@lilyfromseattle lilyfromseattle commented Dec 17, 2025

This PR resolves DIAM-69

Description

The ticket description said this story was to track clicks on the "Complete Profile" button, which already had tracking implemented. However in the link from cohesion there was a comment saying A user taps on the complete your profile prompt within the activity panel so that's what I added.

Screenshot 2025-12-17 at 1 50 52 PM Screenshot 2025-12-17 at 2 27 02 PM

PR Checklist

  • I have tested my changes on the following platforms:
    • Android.
    • iOS.
  • I hid my changes behind a feature flag, or they don't need one.
  • I have included screenshots or videos at least on Android, or I have not changed the UI.
  • I have added tests, or my changes don't require any.
  • I added an app state migration, or my changes do not require one.
  • I have documented any follow-up work that this PR will require, or it does not require any.
  • I have added a changelog entry below, or my changes do not require one.

To the reviewers 👀

  • I would like at least one of the reviewers to run this PR on the simulator or device.
Changelog updates

Changelog updates

Cross-platform user-facing changes

iOS user-facing changes

Android user-facing changes

Dev changes

  • added tracking for complete profile notification clicks

Need help with something? Have a look at our docs, or get in touch with us.

gkartalis
gkartalis previously approved these changes Jan 5, 2026
Copy link
Member

@gkartalis gkartalis left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

nice 🙏

JanaeHijaz
JanaeHijaz previously approved these changes Jan 5, 2026
Copy link
Member

@anandaroop anandaroop left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Lgtm just one Apostrophe Cop 👮🏽‍♂️ comment below…

iskounen
iskounen previously approved these changes Jan 5, 2026
@artsy artsy deleted a comment from ArtsyOpenSource Jan 5, 2026
@ArtsyOpenSource
Copy link
Contributor

This PR contains the following changes:

  • Dev changes (added tracking for complete profile notification clicks - lilyfromseattle)

Generated by 🚫 dangerJS against d05c868

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

7 participants