-
Notifications
You must be signed in to change notification settings - Fork 594
feat: add Typeform embed support with /typeform/:id route #13033
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Conversation
Implements a new modal screen for displaying Typeform surveys using the
Typeform embed SDK. The component integrates with analytics tracking to monitor
survey engagement.
Key features:
- Embeds Typeform surveys via WebView using the official embed.js SDK
- Modal presentation with custom header ("Survey")
- Tracks survey viewed, submitted, and abandoned events
- Fullscreen form display with hidden Typeform branding
- Thank you screen with close button after submission
- Generic survey tracking hook for reusability
Technical implementation:
- New /typeform/:id route with alwaysPresentModally option
- WebView with HTML embedding Typeform SDK's createWidget() API
- Event handling via window.ReactNativeWebView.postMessage bridge
- Renamed useTypeformTracking to useSurveyTracking for generic use
- CSS to ensure fullscreen display and hide Typeform close button
MounirDhahri
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Really nice! This opens so many opportunities!
| queries: [TagScreenQuery], | ||
| }, | ||
| { | ||
| path: "/typeform/:id", |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
nice! maybe we can add this to AndroidManifest.xml to allow opening this with a deep link
| action: "surveySubmitted" as ActionType, | ||
| context_screen_owner_type: "survey" as OwnerType, |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
can we add this to cohesion at a later stage 👀
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
nitpiclk: Do you mind moving this within hooks like here
Important
I'm not planning to merge this PR until we have aligned on the survey content and prompt logic.
Description
Implements a new modal screen for displaying Typeform surveys using a customized WebView. The component integrates with analytics tracking to monitor survey engagement.
Key features:
Technical implementation:
Jira: ONYX-1984 🔒
PR Checklist
To the reviewers 👀
Changelog updates
Changelog updates
Cross-platform user-facing changes
Screen Recording
Simulator.Screen.Recording.-.iPhone.16e.-.2025-11-24.at.20.01.17.mov
Need help with something? Have a look at our docs, or get in touch with us.