Skip to content

fix(PBRW-1027): keyboard stays open after saving alert if tap outside during filling the field #12539

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
dariakoko wants to merge 1 commit into
base: main
Choose a base branch
from
Open

fix(PBRW-1027): keyboard stays open after saving alert if tap outside during filling the field #12539

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 3 additions & 1 deletion src/app/Scenes/SavedSearchAlert/SavedSearchAlertForm.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -14,7 +14,7 @@ import { goBack, navigate, popToRoot } from "app/system/navigation/navigate"
import { refreshSavedAlerts } from "app/utils/refreshHelpers"
import { FormikProvider, useFormik } from "formik"
import { useEffect, useState } from "react"
import { Alert, StyleProp, ViewStyle } from "react-native"
import { Alert, Keyboard, StyleProp, ViewStyle } from "react-native"
import { useTracking } from "react-tracking"
import { useFirstMountState } from "react-use/lib/useFirstMountState"
import { Form } from "./Components/Form"
Expand Down Expand Up @@ -88,6 +88,8 @@ export const SavedSearchAlertForm: React.FC<SavedSearchAlertFormProps> = (props)
enableReinitialize: true,
initialErrors: {},
onSubmit: async (values) => {
Keyboard.dismiss()
Copy link

Copilot AI Jul 25, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

[nitpick] Consider adding error handling or checking if the keyboard is actually open before dismissing it. While Keyboard.dismiss() is generally safe to call, it's better practice to be defensive, especially since you mentioned you couldn't reproduce the issue on Android simulator.

Suggested change
Keyboard.dismiss()
if (isKeyboardVisible) {
Keyboard.dismiss()
}

Copilot uses AI. Check for mistakes.

const userAlertSettings: SavedSearchAlertFormValues = {
name: values.name,
email: values.email,
Expand Down