-
Notifications
You must be signed in to change notification settings - Fork 122
docs: Clean-up README #559
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
5fceb2f to
cfef6f8
Compare
1e01e67 to
80c5f38
Compare
| ## Technical Leads | ||
|
|
||
| Every team at Artsy has a Technical Lead who is part of the Core Team (Product Manager, Technical Lead, Data Analyst, Product Designer and Engineering Manager). The Technical Lead's key responsibilities are: | ||
| Every team at Artsy has a Technical Lead who is part of the Core Team (Product Manager, Technical Lead, Data |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Do we still have the Technical Lead role? I thought project captains replaced it.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Nice catch! I'll remove it.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Wait, we still have the TL role, we didn't take yet the decision to fully remove it. I'll keep this for now.
|
|
||
| <!-- end_toc --> | ||
| <!-- prettier-ignore-end --> | ||
| <!-- prettier-ignore-end -->undefined |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Is this undefined an artifact that prettier is putting in or another formatter?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Good eye! My guess is there's a bug around here in the pre-commit script.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Nice catch @rabidpaul ! I think I was merging this PR as you were commenting. I created #566 to remove it.
I did try to remove the and at some moment, but the pre-commit hook added them back, maybe undefined was added then 🤷 .
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@joeyAghion : Created this PR to fix the pre commit hook and make the commit fail, in case there's an error.
tl;dr: Documentation cleanup and maintenance
This PR removes outdated and unmaintained documentation, fixes broken links, and improves formatting across the README repository: