feat: add daemon command and gRPC list support
#46
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
MatteoPologruto
force-pushed
the
daemon-grpc
branch
from
dc206b4 to
ba718f5
Compare
cmaglie
requested changes
Dec 10, 2025
service/service_list.go
Outdated
Comment on lines
35
to
38
| latest := false | ||
| if manifest.Releases[i].Version == manifest.Latest.Version { | ||
| latest = true | ||
| } |
Member
There was a problem hiding this comment.
Suggested change
| latest := false | |
| if manifest.Releases[i].Version == manifest.Latest.Version { | |
| latest = true | |
| } | |
| latest := (manifest.Releases[i].Version == manifest.Latest.Version) |
Also, it's unclear why you're looping in reverse here.
Contributor
Author
There was a problem hiding this comment.
The json manifest we get contains the latest release in the last element of the array, but we decided that we want to return it as the first item of Releases
Member
There was a problem hiding this comment.
We should not depend on how the input data is sorted; it happens to be that way, but it is not guaranteed.
Co-authored-by: Cristian Maglie <c.maglie@bug.st>
MatteoPologruto
force-pushed
the
daemon-grpc
branch
from
974c302 to
d3b72e1
Compare
lucarin91
requested changes
Dec 10, 2025
| protoc:compile: | ||
| desc: Compile protobuf definitions | ||
| cmds: | ||
| - buf dep update |
Contributor
There was a problem hiding this comment.
I would install buf as a go tool. You can run go get --tool github.com/bufbuild/buf to add the latest buf version in the go.mod, and then here you can write
Suggested change
| - buf dep update | |
| - go tool buf dep update |
|
|
||
| daemonCommand.Flags().StringVar(&daemonPort, | ||
| "port", "50052", | ||
| i18n.Tr("The TCP port the daemon will listen to")) |
Contributor
There was a problem hiding this comment.
Suggested change
| i18n.Tr("The TCP port the daemon will listen to")) | |
| i18n.Tr("The TCP port the daemon will listen to, 0 for random port")) |
Comment on lines
+30
to
+33
| "github.com/arduino/arduino-flasher-cli/cmd/feedback" | ||
| "github.com/arduino/arduino-flasher-cli/cmd/i18n" | ||
|
|
||
| flasher "github.com/arduino/arduino-flasher-cli/rpc/cc/arduino/flasher/v1" |
Contributor
There was a problem hiding this comment.
Suggested change
| "github.com/arduino/arduino-flasher-cli/cmd/feedback" | |
| "github.com/arduino/arduino-flasher-cli/cmd/i18n" | |
| flasher "github.com/arduino/arduino-flasher-cli/rpc/cc/arduino/flasher/v1" | |
| "github.com/arduino/arduino-flasher-cli/cmd/feedback" | |
| "github.com/arduino/arduino-flasher-cli/cmd/i18n" | |
| flasher "github.com/arduino/arduino-flasher-cli/rpc/cc/arduino/flasher/v1" |
| } | ||
|
|
||
| daemonCommand.Flags().StringVar(&daemonPort, | ||
| "port", "50052", |
Contributor
There was a problem hiding this comment.
I would use a random port by default
Suggested change
| "port", "50052", | |
| "port", "0", |
Comment on lines
+35
to
+39
| latest := false | ||
| if manifest.Releases[i].Version == manifest.Latest.Version { | ||
| latest = true | ||
| } | ||
| resp.Releases = append(resp.Releases, &flasher.Release{BuildId: manifest.Releases[i].Version, Latest: latest}) |
Contributor
There was a problem hiding this comment.
Cannot this be simplified in the following?
Suggested change
| latest := false | |
| if manifest.Releases[i].Version == manifest.Latest.Version { | |
| latest = true | |
| } | |
| resp.Releases = append(resp.Releases, &flasher.Release{BuildId: manifest.Releases[i].Version, Latest: latest}) | |
| resp.Releases = append(resp.Releases, &flasher.Release{ | |
| BuildId: manifest.Releases[i].Version, | |
| Latest: manifest.Releases[i].Version == manifest.Latest.Version | |
| }) |
| list.NewListCmd(), | ||
| download.NewDownloadCmd(), | ||
| version.NewVersionCmd(Version), | ||
| daemon.NewDaemonCommand(srv), |
Contributor
There was a problem hiding this comment.
Suggested change
| daemon.NewDaemonCommand(srv), | |
| daemon.NewDaemonCommand(service.NewFlasherServer()), |
Comment on lines
+42
to
+43
| srv := service.NewFlasherServer() | ||
|
|
Contributor
There was a problem hiding this comment.
Suggested change
| srv := service.NewFlasherServer() |
|
|
||
| func (r daemonResult) String() string { | ||
| j, _ := json.Marshal(r) | ||
| return fmt.Sprintln(i18n.Tr("Daemon is now listening on %s:%s", r.IP, r.Port)) + fmt.Sprintln(string(j)) |
Contributor
There was a problem hiding this comment.
Why are you including the JSON?
Suggested change
| return fmt.Sprintln(i18n.Tr("Daemon is now listening on %s:%s", r.IP, r.Port)) + fmt.Sprintln(string(j)) | |
| return fmt.Sprintln(i18n.Tr("Daemon is now listening on %s:%s", r.IP, r.Port)) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation
Add gRPC
daemonsupport for thelistfunction.Change description
Add gRPC
daemonsupport for thelistfunction.Additional Notes
It can be tested following these steps:
Reviewer checklist
main.