-
Notifications
You must be signed in to change notification settings - Fork 83
add SLH-DSA-SHA2-128s signatures to TS SDK #802
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Conversation
ec69441 to
66e01f9
Compare
852a350 to
bcfd2c6
Compare
26e50ed to
58a955a
Compare
Co-authored-by: Maayan <maayan@aptoslabs.com>
58a955a to
88834fc
Compare
Co-authored-by: Maayan <maayan@aptoslabs.com>
e3a7534 to
90b4b90
Compare
0xmaayan
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
| "@aptos-labs/aptos-client": "^2.1.0", | ||
| "@noble/curves": "^1.9.0", | ||
| "@noble/hashes": "^1.5.0", | ||
| "@noble/post-quantum": "^0.5.2", |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This should be an optional dependency. There have been multiple requests that our SDK is too big by default
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
How do we do that? Since if the AIP passes, enshrining this PQ scheme on Aptos, then the SDK would need to support it => this dependency needs to be in.
Description
Builds on top of aptos-labs/aptos-core#18300 by adding support for creating post-quantum signatures (as per AIP-137).
Specifically, adds support for SLH-DSA-SHA2-128s:
Steps to confirm this works with an Aptos node
First, have Docker launched and set up a local net:
Then, run the e2e TXN submission test:
Note
I have already ensured tests pass on a local net deployed from this modified
aptos-corebranch: aptos-labs/aptos-core#18300Tasks
pnpm test/pnpm jestto work with @noble-post-quantumaptos-coreaptos-corefromDerivationPathfor the private key using "SLH-DSA-SHA2-128s seed" as theCurveparameter andnset toTest Plan
Checklist
pnpm fmt?CHANGELOG.md?